Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DH-189] Enable VSCode in Ischool Hub #5257

Merged
merged 3 commits into from
Dec 8, 2023
Merged

[DH-189] Enable VSCode in Ischool Hub #5257

merged 3 commits into from
Dec 8, 2023

Conversation

balajialg
Copy link
Contributor

@balajialg balajialg commented Dec 8, 2023

JIRA ticket - https://jira-secure.berkeley.edu/browse/DH-189

Github Ref: #5251

Referred to Stat 159 hub PRs that enabled VSCode,

#4363
#4360

Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I don't know if code-server still needs nodejs < 17. You could try setting nodejs to something like 18, and testing on staging. Or you can commit as-is and it will probably work.

@balajialg
Copy link
Contributor Author

@ryanlovett just upgraded to nodejs version 18. Lets test it in staging

@balajialg
Copy link
Contributor Author

balajialg commented Dec 8, 2023

@ryanlovett code-server still requires node-js <17. I am reverting nodejs to version 16 for now

@balajialg balajialg merged commit b23df11 into berkeley-dsep-infra:staging Dec 8, 2023
20 checks passed
@ryanlovett
Copy link
Collaborator

@balajialg Thanks for checking the nodejs dependency!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants